rFSM service_launch_rfsm design question

Is there a design reason why the 'service_launch_rfsm' convenience
function doesn't create an input event port for its hosting component?

I was playing around with having a component load a rFSM as a service
using the service_launch_rfsm function. But then realized I had no way
to interact with that FSM. Either this was a simple oversight or it was
a purposeful design decision to not allow/promote such behavior.

If it's just an oversight, I have a patch I can submit for merge request.

JD

rFSM service_launch_rfsm design question

Hi JD,

On Wed, Aug 01, 2012 at 10:29:21AM -0500, J.D. Yamokoski wrote:
> Is there a design reason why the 'service_launch_rfsm' convenience
> function doesn't create an input event port for its hosting component?
>
> I was playing around with having a component load a rFSM as a service
> using the service_launch_rfsm function. But then realized I had no way
> to interact with that FSM. Either this was a simple oversight or it was
> a purposeful design decision to not allow/promote such behavior.
>
> If it's just an oversight, I have a patch I can submit for merge request.

Not really an oversight, but rather not gotten around to implement it
:-) Patch is welcome, but should be consistent with the ev_inport
parameter of 'component_launch_rfsm'. We should then probably also
convert the individual parameters to an table of options, similar to
the latter since it's growing long.

Markus

rFSM service_launch_rfsm design question

On Wed, Aug 1, 2012 at 9:30 PM, Markus Klotzbuecher
<markus [dot] klotzbuecher [..] ...> wrote:
> Hi JD,
>
> On Wed, Aug 01, 2012 at 10:29:21AM -0500, J.D. Yamokoski wrote:
>> Is there a design reason why the 'service_launch_rfsm' convenience
>> function doesn't create an input event port for its hosting component?
>>
>> I was playing around with having a component load a rFSM as a service
>> using the service_launch_rfsm function. But then realized I had no way
>> to interact with that FSM. Either this was a simple oversight or it was
>> a purposeful design decision to not allow/promote such behavior.
>>
>> If it's just an oversight, I have a patch I can submit for merge request.
>
> Not really an oversight, but rather not gotten around to implement it
> :-) Patch is welcome, but should be consistent with the ev_inport
> parameter of 'component_launch_rfsm'. We should then probably also
> convert the individual parameters to an table of options, similar to
> the latter since it's growing long.

Has this been fixed yet ?

Peter

rFSM service_launch_rfsm design question

On Sun, Sep 30, 2012 at 11:14:43PM +0200, Peter Soetens wrote:
> On Wed, Aug 1, 2012 at 9:30 PM, Markus Klotzbuecher
> <markus [dot] klotzbuecher [..] ...> wrote:
> > Hi JD,
> >
> > On Wed, Aug 01, 2012 at 10:29:21AM -0500, J.D. Yamokoski wrote:
> >> Is there a design reason why the 'service_launch_rfsm' convenience
> >> function doesn't create an input event port for its hosting component?
> >>
> >> I was playing around with having a component load a rFSM as a service
> >> using the service_launch_rfsm function. But then realized I had no way
> >> to interact with that FSM. Either this was a simple oversight or it was
> >> a purposeful design decision to not allow/promote such behavior.
> >>
> >> If it's just an oversight, I have a patch I can submit for merge request.
> >
> > Not really an oversight, but rather not gotten around to implement it
> > :-) Patch is welcome, but should be consistent with the ev_inport
> > parameter of 'component_launch_rfsm'. We should then probably also
> > convert the individual parameters to an table of options, similar to
> > the latter since it's growing long.
>
> Has this been fixed yet ?

Not by me, at least...
Markus