[Bug 671] New: OCL fails to build with missing "ocl-config.h"

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=671

Summary: OCL fails to build with missing "ocl-config.h"
Product: OCL
Version: trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: Other
AssignedTo: orocos-dev [..] ...
ReportedBy: kiwi [dot] net [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

r30204 added "include ocl-config.h" to ocl/OCL.hpp, but doesn't install the
ocl-config.h file. OCL itself compiles, but user code that needs the
ComponentLoader (which uses OCL.hpp) does not.

Fix is to add "ocl-config.h" to the GLOBAL_ADD_INCLUDE() line in
ocl/CMakeLists.txt (sorry, can't get patch on internet right now)

[Bug 671] OCL fails to build with missing "ocl-config.h"

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=671

Peter Soetens <peter [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |peter [..] ...
Resolution| |FIXED
Status|NEW |RESOLVED

--- Comment #1 from Peter Soetens <peter [..] ...> 2009-06-12 16:12:16 ---
(In reply to comment #0)
> r30204 added "include ocl-config.h" to ocl/OCL.hpp, but doesn't install the
> ocl-config.h file. OCL itself compiles, but user code that needs the
> ComponentLoader (which uses OCL.hpp) does not.
>
> Fix is to add "ocl-config.h" to the GLOBAL_ADD_INCLUDE() line in
> ocl/CMakeLists.txt (sorry, can't get patch on internet right now)

Thanks for reporting. If added it to the main CMakeLists.txt file, with the
other generated files:

&#10;diff --git a/CMakeLists.txt b/CMakeLists.txt&#10;index 6578e39..8f45d06 100644&#10;--- a/CMakeLists.txt&#10;+++ b/CMakeLists.txt&#10;@@ -199,6 +199,7 @@ SET(OROCOS_COMPONENTS_REQUIRES&#10;&quot;$ENV{OROCOS_COMPONENTS_REQUIRES}&quot;)&#10; CONFIGURE_FILE( ${PROJ_SOURCE_DIR}/ocl/ocl-config.h.in&#10;${PROJ_BINARY_DIR}/ocl/ocl-config.h @ONLY)&#10; CONFIGURE_FILE( ${PROJ_SOURCE_DIR}/orocos-ocl.pc.in&#10;${PROJ_BINARY_DIR}/orocos-ocl-${OROCOS_TARGET}.pc @ONLY)&#10; INSTALL_FILES( /lib/pkgconfig FILES orocos-ocl-${OROCOS_TARGET}.pc)&#10;+INSTALL_FILES( /include/ocl FILES ocl/ocl-config.h)&#10;&#10; #MESSAGE(&quot;Selected dirs: $ENV{SELECTED_DIRS}&quot;)&#10; #SET(SELECTED_DIRS $ENV{SELECTED_DIRS})&#10;

kaltan@vader:~/src/git/orocos-ocl$ git commit -a -m"Fix bug #671: OCL fails to
build with missing ocl-config.h
>
> Add ocl/ocl-config.h to the INSTALL_FILES list of generated files.
> "
Created commit 94cddc1: Fix bug #671: OCL fails to build with missing
ocl-config.h
1 files changed, 1 insertions(+), 0 deletions(-)

Fixed in r30210

Peter