[Bug 697] New: RTT trunk v1.10 build fails

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697

Summary: RTT trunk v1.10 build fails
Product: RTT
Version: rtt-trunk
Platform: All
OS/Version: Mac OS X
Status: NEW
Severity: normal
Priority: P3
Component: Real-Time Toolkit (RTT)
AssignedTo: orocos-dev [..] ...
ReportedBy: kiwi [dot] net [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

Same errors seen in Ubuntu Jaunty.

Should we create individual bug reports for these kind of bugs? Or one bug
report per vx.y version, and append? Or ...?

{{{
[ 52%] Building CXX object
src/CMakeFiles/orocos-rtt-dynamic_macosx.dir/scripting/DumpObject.cpp.o
/opt/dashboard/code/orocos/trunk-svn/rtt/src/os/Thread.cpp: In function ‘void*
RTT::OS::thread_function(void*)’:
/opt/dashboard/code/orocos/trunk-svn/rtt/src/os/Thread.cpp:88: warning: unused
variable ‘bit’
}}}

{{{
Index: src/os/Thread.cpp
===================================================================
--- src/os/Thread.cpp (revision 30435)
+++ src/os/Thread.cpp (working copy)
@@ -85,7 +85,6 @@
task->configure();

// order thread scope toggle bit on thread number
- unsigned int bit = task->threadNumber();
SCOPE_OFF

int overruns = 0;
}}}

{{{
[ 15%] Building CXX object
src/CMakeFiles/orocos-rtt-dynamic_macosx.dir/EventC.cpp.o
/opt/dashboard/code/orocos/trunk-svn/rtt/src/ConnectionInterface.hpp: In
constructor ‘RTT::ConnectionInterface::ConnectionInterface()’:
/opt/dashboard/code/orocos/trunk-svn/rtt/src/ConnectionInterface.hpp:110:
warning: ‘RTT::ConnectionInterface::mconnected’ will be initialized after
/opt/dashboard/code/orocos/trunk-svn/rtt/src/ConnectionInterface.hpp:106:
warning: ‘RTT::OS::AtomicInt RTT::ConnectionInterface::refcount’
/opt/dashboard/code/orocos/trunk-svn/rtt/src/ConnectionInterface.cpp:46:
warning: when initialized here
}}}

{{{
Index: src/ConnectionInterface.cpp
===================================================================
--- src/ConnectionInterface.cpp (revision 30435)
+++ src/ConnectionInterface.cpp (working copy)
@@ -44,7 +44,7 @@
{

ConnectionInterface::ConnectionInterface()
- : mconnected(false), refcount(0)
+ : refcount(0), mconnected(false)
{}

ConnectionInterface::~ConnectionInterface()
}}}

--
Configure bugmail: https://www.fmtc.be/bugzilla/orocos/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev

[Bug 697] RTT trunk v1.10 build fails

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697

Peter Soetens <peter [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |peter [..] ...
Resolution| |FIXED
Status|NEW |RESOLVED

--- Comment #1 from Peter Soetens <peter [..] ...> 2009-08-26 16:09:52 ---
(In reply to comment #0)
> Same errors seen in Ubuntu Jaunty.
>
> Should we create individual bug reports for these kind of bugs? Or one bug
> report per vx.y version, and append? Or ...?

Small things like this can go directly though the -dev mailing list. I see
bugzilla more as a longer-term tracking thing while we're working on something
with no obvious solution.

Patches applied.

Peter

[Bug 697] RTT trunk v1.10 build fails

On Aug 26, 2009, at 10:09 , Peter Soetens wrote:

> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>
>
> Peter Soetens <peter [..] ...> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |peter [..] ...
> Resolution| |FIXED
> Status|NEW |RESOLVED
>
>
>
>
> --- Comment #1 from Peter Soetens <peter [..] ...>
> 2009-08-26 16:09:52 ---
> (In reply to comment #0)
>> Same errors seen in Ubuntu Jaunty.
>>
>> Should we create individual bug reports for these kind of bugs? Or
>> one bug
>> report per vx.y version, and append? Or ...?
>
> Small things like this can go directly though the -dev mailing list.
> I see
> bugzilla more as a longer-term tracking thing while we're working on
> something
> with no obvious solution.
>
> Patches applied.
>
> Peter

Unit test failures.

On Mac OS X Leopard at r30435
{{{
rtt $ ./tests/task-test
Running 21 test cases...
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:276:
error in "testOverrun": Failed to detect step overrun in Thread
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:278:
error in "testOverrun": Failed to execute finalize in emergencyStop
2.515 [CRITICAL][PeriodicThread::stop] The ORThread thread seems to be
blocked ( ret was 49 .)
12.784 [ FATAL ][Activity] Activity caught an unknown C++ exception,
stopped thread !

*** 2 failures detected in test suite "Master Test Suite"

rtt $ ./tests/program-test
Running 19 test cases...
Asserted :0 with :Program script did not detect exported function
failure.
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:334:
error in "testFunctionFail": Runtime error encountered on line 12.

/opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:335:
error in "testFunctionFail": Program stalled on line 12.

*** 2 failures detected in test suite "Master Test Suite"
}}}

An Ubuntu Jaunty at r30435
{{{
sroderick@ubuntu rtt $ ./tests/task-test
Running 21 test cases...
9.358 [ FATAL ][Activity] Activity caught an unknown C++ exception,
stopped thread !
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(276):
error in "testOverrun": Failed to detect step overrun in Thread
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(278):
error in "testOverrun": Failed to execute finalize in emergencyStop
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(296):
error in "testThread": Step not executed

*** 3 failures detected in test suite "Master Test Suite"

}}}

[Bug 697] RTT trunk v1.10 build fails

On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>
>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>
>>
>> Peter Soetens <peter [..] ...> changed:
>>
>>          What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>                CC|                            |peter [..] ...
>>        Resolution|                            |FIXED
>>            Status|NEW                         |RESOLVED
>>
>>
>>
>>
>> --- Comment #1 from Peter Soetens <peter [..] ...>  2009-08-26
>> 16:09:52 ---
>> (In reply to comment #0)
>>>
>>> Same errors seen in Ubuntu Jaunty.
>>>
>>> Should we create individual bug reports for these kind of bugs? Or one
>>> bug
>>> report per vx.y version, and append? Or ...?
>>
>> Small things like this can go directly though the -dev mailing list. I see
>> bugzilla more as a longer-term tracking thing while we're working on
>> something
>> with no obvious solution.
>>
>> Patches applied.
>>
>> Peter
>
>
> Unit test failures.

I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
most of these issues. The only think I'm puzzled about is the
function_test failure, which we actually fixed and is quite OS
independent, so I don't understand why its failing on macosx and not
on gnulinux...

SVN trunk now also has the CDash stuff in.

Peter

>
> On Mac OS X Leopard at r30435
> {{{
> rtt $ ./tests/task-test
> Running 21 test cases...
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:276: error in
> "testOverrun": Failed to detect step overrun in Thread
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:278: error in
> "testOverrun": Failed to execute finalize in emergencyStop
> 2.515 [CRITICAL][PeriodicThread::stop] The ORThread thread seems to be
> blocked ( ret was 49 .)
> 12.784 [ FATAL  ][Activity] Activity caught an unknown C++ exception,
> stopped thread !
>
> *** 2 failures detected in test suite "Master Test Suite"
>
> rtt $ ./tests/program-test
> Running 19 test cases...
> Asserted :0 with :Program script did not detect exported function failure.
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:334: error
> in "testFunctionFail": Runtime error encountered on line 12.
>
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:335: error
> in "testFunctionFail": Program stalled on line 12.
>
>
> *** 2 failures detected in test suite "Master Test Suite"
> }}}
>
>
>
> An Ubuntu Jaunty at r30435
> {{{
> sroderick@ubuntu rtt $ ./tests/task-test
> Running 21 test cases...
> 9.358 [ FATAL  ][Activity] Activity caught an unknown C++ exception, stopped
> thread !
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(276): error in
> "testOverrun": Failed to detect step overrun in Thread
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(278): error in
> "testOverrun": Failed to execute finalize in emergencyStop
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(296): error in
> "testThread": Step not executed
>
> *** 3 failures detected in test suite "Master Test Suite"
>
> }}}
>

[Bug 697] RTT trunk v1.10 build fails

On Aug 26, 2009, at 18:33 , Peter Soetens wrote:

> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>
>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>
>>>
>>> Peter Soetens <peter [..] ...> changed:
>>>
>>> What |Removed |Added
>>>
>>> ----------------------------------------------------------------------------
>>> CC| |peter [..] ...
>>> Resolution| |FIXED
>>> Status|NEW |RESOLVED
>>>
>>>
>>>
>>>
>>> --- Comment #1 from Peter Soetens <peter [..] ...>
>>> 2009-08-26
>>> 16:09:52 ---
>>> (In reply to comment #0)
>>>>
>>>> Same errors seen in Ubuntu Jaunty.
>>>>
>>>> Should we create individual bug reports for these kind of bugs?
>>>> Or one
>>>> bug
>>>> report per vx.y version, and append? Or ...?
>>>
>>> Small things like this can go directly though the -dev mailing
>>> list. I see
>>> bugzilla more as a longer-term tracking thing while we're working on
>>> something
>>> with no obvious solution.
>>>
>>> Patches applied.
>>>
>>> Peter
>>
>>
>> Unit test failures.
>
> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
> most of these issues. The only think I'm puzzled about is the
> function_test failure, which we actually fixed and is quite OS
> independent, so I don't understand why its failing on macosx and not
> on gnulinux...

gnulinux now tests clean.

macosx still gives ...

{{{
4/ 11 Testing task-test
Test command: /opt/dashboard/build/orocos/trunk-svn/rtt/tests/task-test
Test timeout computed to be: 9.99988e+06
Running 21 test cases...
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:282:
error in "testOverrun": Failed to detect step overrun in Thread
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:284:
error in "testOverrun": Failed to execute finalize in emergencyStop
2.515 [CRITICAL][PeriodicThread::stop] The ORThread thread seems to be
blocked ( ret was 49 .)

*** 2 failures detected in test suite "Master Test Suite"
-- Process completed
***Failed

8/ 11 Testing program-test
Test command: /opt/dashboard/build/orocos/trunk-svn/rtt/tests/program-
test
Test timeout computed to be: 9.99988e+06
Running 19 test cases...
Asserted :0 with :Program script did not detect exported function
failure.
/opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:334:
error in "testFunctionFail": Runtime error encountered on line 12.

/opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:335:
error in "testFunctionFail": Program stalled on line 12.

}}}

[Bug 697] RTT trunk v1.10 build fails

On Thu, Aug 27, 2009 at 03:59, Stephen Roderick<kiwi [dot] net [..] ...> wrote:
> On Aug 26, 2009, at 18:33 , Peter Soetens wrote:
>
>> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>>>
>>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>>
>>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>>
>>>>
>>>> Peter Soetens <peter [..] ...> changed:
>>>>
>>>>         What    |Removed                     |Added
>>>>
>>>>
>>>> ----------------------------------------------------------------------------
>>>>               CC|                            |peter [..] ...
>>>>       Resolution|                            |FIXED
>>>>           Status|NEW                         |RESOLVED
>>>>
>>>>
>>>>
>>>>
>>>> --- Comment #1 from Peter Soetens <peter [..] ...>  2009-08-26
>>>> 16:09:52 ---
>>>> (In reply to comment #0)
>>>>>
>>>>> Same errors seen in Ubuntu Jaunty.
>>>>>
>>>>> Should we create individual bug reports for these kind of bugs? Or one
>>>>> bug
>>>>> report per vx.y version, and append? Or ...?
>>>>
>>>> Small things like this can go directly though the -dev mailing list. I
>>>> see
>>>> bugzilla more as a longer-term tracking thing while we're working on
>>>> something
>>>> with no obvious solution.
>>>>
>>>> Patches applied.
>>>>
>>>> Peter
>>>
>>>
>>> Unit test failures.
>>
>> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
>> most of these issues. The only think I'm puzzled about is the
>> function_test failure, which we actually fixed and is quite OS
>> independent, so I don't understand why its failing on macosx and not
>> on gnulinux...
>
> gnulinux now tests clean.
>
> macosx still gives ...
>
> {{{
>  4/ 11 Testing task-test
> Test command: /opt/dashboard/build/orocos/trunk-svn/rtt/tests/task-test
> Test timeout computed to be: 9.99988e+06
> Running 21 test cases...
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:282: error in
> "testOverrun": Failed to detect step overrun in Thread
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:284: error in
> "testOverrun": Failed to execute finalize in emergencyStop
> 2.515 [CRITICAL][PeriodicThread::stop] The ORThread thread seems to be
> blocked ( ret was 49 .)
>
> *** 2 failures detected in test suite "Master Test Suite"
> -- Process completed
> ***Failed

>
>
>  8/ 11 Testing program-test
> Test command: /opt/dashboard/build/orocos/trunk-svn/rtt/tests/program-test
> Test timeout computed to be: 9.99988e+06
> Running 19 test cases...
> Asserted :0 with :Program script did not detect exported function failure.
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:334: error
> in "testFunctionFail": Runtime error encountered on line 12.
>
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:335: error
> in "testFunctionFail": Program stalled on line 12.
>
>
> }}}
>

Are you absolutely sure that these patches are in your macosx build ?
Linking against old libraries ??

&#10;diff --git a/src/CommandExecFunction.hpp b/src/CommandExecFunction.hpp&#10;index 3af64f3..d4c86f6 100644&#10;--- a/src/CommandExecFunction.hpp&#10;+++ b/src/CommandExecFunction.hpp&#10;@@ -168,7 +168,7 @@ namespace RTT&#10;         }&#10;&#10;         virtual bool valid() const {&#10;-            return maccept-&gt;get();&#10;+            return maccept-&gt;get() &amp;&amp; ! _foo-&gt;inError();&#10;         }&#10;&#10;         virtual bool done() const {&#10;diff --git a/src/ProgramInterface.cpp b/src/ProgramInterface.cpp&#10;index 93dafc7..c57df62 100644&#10;--- a/src/ProgramInterface.cpp&#10;+++ b/src/ProgramInterface.cpp&#10;@@ -56,7 +56,7 @@ namespace RTT&#10;         if (pp) {&#10;             pStatus = Status::stopped;&#10;         }else {&#10;-            pStatus = Status::unloaded;&#10;+            // preserve current pStatus for client reference.&#10;             this-&gt;handleUnload();&#10;         }&#10;     }&#10;

Peter

[Bug 697] RTT trunk v1.10 build fails

On Aug 26, 2009, at 18:33 , Peter Soetens wrote:

> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>
>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>
>>>
>>> Peter Soetens <peter [..] ...> changed:
>>>
>>> What |Removed |Added
>>>
>>> ----------------------------------------------------------------------------
>>> CC| |peter [..] ...
>>> Resolution| |FIXED
>>> Status|NEW |RESOLVED
>>>
>>>
>>>
>>>
>>> --- Comment #1 from Peter Soetens <peter [..] ...>
>>> 2009-08-26
>>> 16:09:52 ---
>>> (In reply to comment #0)
>>>>
>>>> Same errors seen in Ubuntu Jaunty.
>>>>
>>>> Should we create individual bug reports for these kind of bugs?
>>>> Or one
>>>> bug
>>>> report per vx.y version, and append? Or ...?
>>>
>>> Small things like this can go directly though the -dev mailing
>>> list. I see
>>> bugzilla more as a longer-term tracking thing while we're working on
>>> something
>>> with no obvious solution.
>>>
>>> Patches applied.
>>>
>>> Peter
>>
>>
>> Unit test failures.
>
> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
> most of these issues. The only think I'm puzzled about is the
> function_test failure, which we actually fixed and is quite OS
> independent, so I don't understand why its failing on macosx and not
> on gnulinux...
>
> SVN trunk now also has the CDash stuff in.

Last one, promise ... :-)

{{{
Index: config/FindOmniORB.cmake
===================================================================
--- config/FindOmniORB.cmake (revision 30461)
+++ config/FindOmniORB.cmake (working copy)
@@ -140,7 +140,7 @@
MESSAGE(" omniORB installation...")

SET( OMNIORB4_DIR "" CACHE PATH "Root of omniORB instal tree." )
-ENDIF( OMNIORB4_FOUND )
+ENDIF( NOT OMNIORB4_FOUND )

# Generate all files required for a corba server app.
# ORO_ADD_CORBA_SERVERS( foo_SRCS foo_HPPS file.idl ... )

}}}

[Bug 697] RTT trunk v1.10 build fails

On Thu, Aug 27, 2009 at 03:51, Stephen Roderick<kiwi [dot] net [..] ...> wrote:
> On Aug 26, 2009, at 18:33 , Peter Soetens wrote:
>
>> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>>>
>>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>>
>>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>>
>>>>
>>>> Peter Soetens <peter [..] ...> changed:
>>>>
>>>>         What    |Removed                     |Added
>>>>
>>>>
>>>> ----------------------------------------------------------------------------
>>>>               CC|                            |peter [..] ...
>>>>       Resolution|                            |FIXED
>>>>           Status|NEW                         |RESOLVED
>>>>
>>>>
>>>>
>>>>
>>>> --- Comment #1 from Peter Soetens <peter [..] ...>  2009-08-26
>>>> 16:09:52 ---
>>>> (In reply to comment #0)
>>>>>
>>>>> Same errors seen in Ubuntu Jaunty.
>>>>>
>>>>> Should we create individual bug reports for these kind of bugs? Or one
>>>>> bug
>>>>> report per vx.y version, and append? Or ...?
>>>>
>>>> Small things like this can go directly though the -dev mailing list. I
>>>> see
>>>> bugzilla more as a longer-term tracking thing while we're working on
>>>> something
>>>> with no obvious solution.
>>>>
>>>> Patches applied.
>>>>
>>>> Peter
>>>
>>>
>>> Unit test failures.
>>
>> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
>> most of these issues. The only think I'm puzzled about is the
>> function_test failure, which we actually fixed and is quite OS
>> independent, so I don't understand why its failing on macosx and not
>> on gnulinux...
>>
>> SVN trunk now also has the CDash stuff in.
>
> Last one, promise ... :-)
>
> {{{
> Index: config/FindOmniORB.cmake
> ===================================================================
> --- config/FindOmniORB.cmake    (revision 30461)
> +++ config/FindOmniORB.cmake    (working copy)
> @@ -140,7 +140,7 @@
>   MESSAGE("    omniORB installation...")
>
>   SET( OMNIORB4_DIR "" CACHE PATH "Root of omniORB instal tree." )
> -ENDIF( OMNIORB4_FOUND )
> +ENDIF( NOT OMNIORB4_FOUND )
>
>  # Generate all files required for a corba server app.
>  # ORO_ADD_CORBA_SERVERS( foo_SRCS foo_HPPS file.idl ... )
>
> }}}

Fixed, thanks.

Peter

[Bug 697] RTT trunk v1.10 build fails

On Aug 26, 2009, at 18:33 , Peter Soetens wrote:

> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>
>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>
>>>
>>> Peter Soetens <peter [..] ...> changed:
>>>
>>> What |Removed |Added
>>>
>>> ----------------------------------------------------------------------------
>>> CC| |peter [..] ...
>>> Resolution| |FIXED
>>> Status|NEW |RESOLVED
>>>
>>>
>>>
>>>
>>> --- Comment #1 from Peter Soetens <peter [..] ...>
>>> 2009-08-26
>>> 16:09:52 ---
>>> (In reply to comment #0)
>>>>
>>>> Same errors seen in Ubuntu Jaunty.
>>>>
>>>> Should we create individual bug reports for these kind of bugs?
>>>> Or one
>>>> bug
>>>> report per vx.y version, and append? Or ...?
>>>
>>> Small things like this can go directly though the -dev mailing
>>> list. I see
>>> bugzilla more as a longer-term tracking thing while we're working on
>>> something
>>> with no obvious solution.
>>>
>>> Patches applied.
>>>
>>> Peter
>>
>>
>> Unit test failures.
>
> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
> most of these issues. The only think I'm puzzled about is the
> function_test failure, which we actually fixed and is quite OS
> independent, so I don't understand why its failing on macosx and not
> on gnulinux...
>
> SVN trunk now also has the CDash stuff in.

Also, want to put the breakUpdateHook() code into trunk? I have it as
mod's in my working copy. Works great for us.

{{{
Index: src/TaskCore.hpp
===================================================================
--- src/TaskCore.hpp (revision 30461)
+++ src/TaskCore.hpp (working copy)
@@ -422,6 +422,16 @@
virtual void updateHook();

/**
+ * Implement this function if your code might block for long
times inside
+ * the updateHook() function. Insert in this hook the code to
wake up
+ * that code or signal it otherwise that updateHook() is
requested to return
+ * (for example by setting a flag).
+ * The method returns \a false by default.
+ * @return true if well received and updateHook() will soon
return. False otherwise.
+ */
+ virtual bool breakUpdateHook();
+
+ /**
* Implement this method to contain code that must be executed
* in the RunTimeError state, instead of updateHook(). This
allows
* you to specify the behaviour in an erroneous component.
Index: src/TaskCore.cpp
===================================================================
--- src/TaskCore.cpp (revision 30461)
+++ src/TaskCore.cpp (working copy)
@@ -246,6 +246,11 @@
update();
}

+ bool TaskCore::breakUpdateHook()
+ {
+ return false;
+ }
+
void TaskCore::stopHook()
{
shutdown();
Index: src/ExecutionEngine.cpp
===================================================================
--- src/ExecutionEngine.cpp (revision 30461)
+++ src/ExecutionEngine.cpp (working copy)
@@ -348,7 +348,13 @@
}

bool ExecutionEngine::breakLoop() {
- return true;
+ bool ok = true;
+ if (taskc)
+ ok = taskc->breakUpdateHook();
+ for (std::vector<TaskCore*>::iterator it = children.begin();
it != children.end();++it) {
+ ok = (*it)->breakUpdateHook() && ok;
+ }
+ return ok;
}

void ExecutionEngine::finalize() {

}}}

[Bug 697] RTT trunk v1.10 build fails

On Aug 26, 2009, at 18:33 , Peter Soetens wrote:

> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>
>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>
>>>
>>> Peter Soetens <peter [..] ...> changed:
>>>
>>> What |Removed |Added
>>>
>>> ----------------------------------------------------------------------------
>>> CC| |peter [..] ...
>>> Resolution| |FIXED
>>> Status|NEW |RESOLVED
>>>
>>>
>>>
>>>
>>> --- Comment #1 from Peter Soetens <peter [..] ...>
>>> 2009-08-26
>>> 16:09:52 ---
>>> (In reply to comment #0)
>>>>
>>>> Same errors seen in Ubuntu Jaunty.
>>>>
>>>> Should we create individual bug reports for these kind of bugs?
>>>> Or one
>>>> bug
>>>> report per vx.y version, and append? Or ...?
>>>
>>> Small things like this can go directly though the -dev mailing
>>> list. I see
>>> bugzilla more as a longer-term tracking thing while we're working on
>>> something
>>> with no obvious solution.
>>>
>>> Patches applied.
>>>
>>> Peter
>>
>>
>> Unit test failures.
>
> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
> most of these issues. The only think I'm puzzled about is the
> function_test failure, which we actually fixed and is quite OS
> independent, so I don't understand why its failing on macosx and not
> on gnulinux...
>
> SVN trunk now also has the CDash stuff in.

CDash stuff looks good. More patches below

{{{
Index: src/Types.cpp
===================================================================
--- src/Types.cpp (revision 30461)
+++ src/Types.cpp (working copy)
@@ -38,6 +38,7 @@

#include "rtt-config.h"

+#include <sstream>
#include <MultiVector.hpp>
#include <Logger.hpp>
#include "Attribute.hpp"
Index: src/os/Thread.cpp
===================================================================
--- src/os/Thread.cpp (revision 30461)
+++ src/os/Thread.cpp (working copy)
@@ -86,7 +86,6 @@

#ifdef OROPKG_OS_THREAD_SCOPE
// order thread scope toggle bit on thread number
- unsigned int bit = task->threadNumber();
#endif
SCOPE_OFF
}}}

[Bug 697] RTT trunk v1.10 build fails

On Thu, Aug 27, 2009 at 03:42, Stephen Roderick<kiwi [dot] net [..] ...> wrote:
> On Aug 26, 2009, at 18:33 , Peter Soetens wrote:
>
>> On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
>>>
>>> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>>>
>>>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>>>
>>>>
>>>> Peter Soetens <peter [..] ...> changed:
>>>>
>>>>         What    |Removed                     |Added
>>>>
>>>>
>>>> ----------------------------------------------------------------------------
>>>>               CC|                            |peter [..] ...
>>>>       Resolution|                            |FIXED
>>>>           Status|NEW                         |RESOLVED
>>>>
>>>>
>>>>
>>>>
>>>> --- Comment #1 from Peter Soetens <peter [..] ...>  2009-08-26
>>>> 16:09:52 ---
>>>> (In reply to comment #0)
>>>>>
>>>>> Same errors seen in Ubuntu Jaunty.
>>>>>
>>>>> Should we create individual bug reports for these kind of bugs? Or one
>>>>> bug
>>>>> report per vx.y version, and append? Or ...?
>>>>
>>>> Small things like this can go directly though the -dev mailing list. I
>>>> see
>>>> bugzilla more as a longer-term tracking thing while we're working on
>>>> something
>>>> with no obvious solution.
>>>>
>>>> Patches applied.
>>>>
>>>> Peter
>>>
>>>
>>> Unit test failures.
>>
>> I pushed fixes to SVN trunk and git rtt-2.0-mainline that should fix
>> most of these issues. The only think I'm puzzled about is the
>> function_test failure, which we actually fixed and is quite OS
>> independent, so I don't understand why its failing on macosx and not
>> on gnulinux...
>>
>> SVN trunk now also has the CDash stuff in.
>
> CDash stuff looks good. More patches below
>
> {{{
> Index: src/Types.cpp
> ===================================================================
> --- src/Types.cpp       (revision 30461)
> +++ src/Types.cpp       (working copy)
> @@ -38,6 +38,7 @@
>
>  #include "rtt-config.h"
>
> +#include <sstream>
>  #include <MultiVector.hpp>
>  #include <Logger.hpp>
>  #include "Attribute.hpp"

sstream is already included in Types.cpp (below), so you can revert this one.

> Index: src/os/Thread.cpp
> ===================================================================
> --- src/os/Thread.cpp   (revision 30461)
> +++ src/os/Thread.cpp   (working copy)
> @@ -86,7 +86,6 @@
>
>  #ifdef OROPKG_OS_THREAD_SCOPE
>             // order thread scope toggle bit on thread number
> -            unsigned int bit = task->threadNumber();
>  #endif
>             SCOPE_OFF
>  }}}
>

This is unnecessary as well, because 'bit' is needed when
OROPKG_OS_THREAD_SCOPE is defined.

Peter

[Bug 697] RTT trunk v1.10 build fails

One of the issues you are seeing is that you don't execute the tests
as root under gnulinux ('step not executed')
The other issues (exported function error and overrun not detected)
I'm looking at.

Maybe the tests should check if we can run high priority threads, and
if not, skip tests that assume we are...

Peter

On Wed, Aug 26, 2009 at 22:47, S Roderick<kiwi [dot] net [..] ...> wrote:
> On Aug 26, 2009, at 10:09 , Peter Soetens wrote:
>
>> https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=697
>>
>>
>> Peter Soetens <peter [..] ...> changed:
>>
>>          What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>                CC|                            |peter [..] ...
>>        Resolution|                            |FIXED
>>            Status|NEW                         |RESOLVED
>>
>>
>>
>>
>> --- Comment #1 from Peter Soetens <peter [..] ...>  2009-08-26
>> 16:09:52 ---
>> (In reply to comment #0)
>>>
>>> Same errors seen in Ubuntu Jaunty.
>>>
>>> Should we create individual bug reports for these kind of bugs? Or one
>>> bug
>>> report per vx.y version, and append? Or ...?
>>
>> Small things like this can go directly though the -dev mailing list. I see
>> bugzilla more as a longer-term tracking thing while we're working on
>> something
>> with no obvious solution.
>>
>> Patches applied.
>>
>> Peter
>
>
> Unit test failures.
>
> On Mac OS X Leopard at r30435
> {{{
> rtt $ ./tests/task-test
> Running 21 test cases...
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:276: error in
> "testOverrun": Failed to detect step overrun in Thread
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp:278: error in
> "testOverrun": Failed to execute finalize in emergencyStop
> 2.515 [CRITICAL][PeriodicThread::stop] The ORThread thread seems to be
> blocked ( ret was 49 .)
> 12.784 [ FATAL  ][Activity] Activity caught an unknown C++ exception,
> stopped thread !
>
> *** 2 failures detected in test suite "Master Test Suite"
>
> rtt $ ./tests/program-test
> Running 19 test cases...
> Asserted :0 with :Program script did not detect exported function failure.
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:334: error
> in "testFunctionFail": Runtime error encountered on line 12.
>
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/function_test.cpp:335: error
> in "testFunctionFail": Program stalled on line 12.
>
>
> *** 2 failures detected in test suite "Master Test Suite"
> }}}
>
>
>
> An Ubuntu Jaunty at r30435
> {{{
> sroderick@ubuntu rtt $ ./tests/task-test
> Running 21 test cases...
> 9.358 [ FATAL  ][Activity] Activity caught an unknown C++ exception, stopped
> thread !
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(276): error in
> "testOverrun": Failed to detect step overrun in Thread
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(278): error in
> "testOverrun": Failed to execute finalize in emergencyStop
> /opt/dashboard/code/orocos/trunk-svn/rtt/tests/tasks_test.cpp(296): error in
> "testThread": Step not executed
>
> *** 3 failures detected in test suite "Master Test Suite"
>
> }}}
>