[Bug 847] New: Fix LUA and OCL build integration

http://bugs.orocos.org/show_bug.cgi?id=847

Summary: Fix LUA and OCL build integration
Product: Toolchain
Version: 2.3.0
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P3
Component: OCL
AssignedTo: orocos-dev [..] ...
ReportedBy: kiwi [dot] net [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

[From recent gitorious merge request]

Peter Soetens commented:

Merged. We'll revert to lua being off, as proposed. I think a better solution
would be to only enable lua when it's headers and libs are found, and then let
the build system override that with build_lua_rtt.

So proposed logic is (in psuedo-cmake)

option(build_lua_rtt default=off)
find(lua optional)
if build_lua_rtt OR lua_found
    # build LUA library
endif


[Bug 847] Fix LUA and OCL build integration

http://bugs.orocos.org/show_bug.cgi?id=847

--- Comment #1 from Peter Soetens <peter [..] ...> 2011-03-14 15:36:48 CET ---
(In reply to comment #0)
> [From recent gitorious merge request]
>
> Peter Soetens commented:
>
> Merged. We'll revert to lua being off, as proposed. I think a better solution
> would be to only enable lua when it's headers and libs are found, and then let
> the build system override that with build_lua_rtt.
>
> So proposed logic is (in psuedo-cmake)
> &#10;&gt; option(build_lua_rtt default=off)&#10;&gt; find(lua optional)&#10;&gt; if build_lua_rtt OR lua_found&#10;&gt; # build LUA library&#10;&gt; endif&#10;&gt;

This is confusing... and not what I meant.

&#10;find(lua optional)&#10;if ( lua_found ) &#10;    option(build_lua_rtt default=on)&#10;else ( lua_found ) &#10;    option(build_lua_rtt default=off)&#10;endif( lua_found )&#10;&#10;# both must be true:&#10;if build_lua_rtt AND lua_found&#10; # build LUA library&#10;endif&#10;

Peter

[Bug 847] New: Fix LUA and OCL build integration

On Mon, Mar 14, 2011 at 02:12:44PM +0100, S Roderick wrote:
>
> http://bugs.orocos.org/show_bug.cgi?id=847
>
> Summary: Fix LUA and OCL build integration
> Product: Toolchain
> Version: 2.3.0
> Platform: All
> OS/Version: All
> Status: NEW
> Severity: enhancement
> Priority: P3
> Component: OCL
> AssignedTo: orocos-dev [..] ...
> ReportedBy: kiwi [dot] net [..] ...
> CC: orocos-dev [..] ...
> Estimated Hours: 0.0
>
>
> [From recent gitorious merge request]
>
> Peter Soetens commented:
>
> Merged. We'll revert to lua being off, as proposed. I think a better solution
> would be to only enable lua when it's headers and libs are found, and then let
> the build system override that with build_lua_rtt.
>
> So proposed logic is (in psuedo-cmake)
> &#10;&gt; option(build_lua_rtt default=off)&#10;&gt; find(lua optional)&#10;&gt; if build_lua_rtt OR lua_found&#10;&gt;     # build LUA library&#10;&gt; endif&#10;&gt;

Yes, please at least add something this.

Markus