[Bug 892] New: orocos_kinematics_dynamics is missing a rosdep on pkg-config


Summary: orocos_kinematics_dynamics is missing a rosdep on
Product: KDL
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: major
Priority: P3
Component: Build system
AssignedTo: orocos-dev [..] ...
ReportedBy: tfoote [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

The debs of orocos_kinematics_dynamics cannot be built due to a missing rosdep
on pkg-config.

"pkg-config" is already defined in the ROS stack so it's just a one line
addition to the manifest.

I believe the prereleases fails to catch this due to it being installed by the
prerelease toolchain, but it is not installed automatically on the debian build
machines any more.

Ruben Smits's picture

[Bug 892] orocos_kinematics_dynamics is missing a rosdep on pkg-


Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
CC| |ruben [dot] smits [..] ...en.b
| |e
Resolution| |FIXED

--- Comment #2 from Ruben Smits <ruben [dot] smits [..] ...> 2011-08-17 09:45:59 CEST ---
Fix is available on the experimental branch of
git.mech.kuleuven.be/robotics/orocos_kinematics_dynamics.git (Beware that Wim
changed the ros_release files to use his own clone, so make sure that he pulls
it in, or change the release system back to our repository.)

commit 4d4220fdcbcd2bd386f0912cc3b9724d33371951
Refs: experimental, <origin/experimental>
Author: Ruben Smits <ruben [dot] smits [..] ...>
AuthorDate: Wed Aug 17 09:42:19 2011 +0200
Commit: Ruben Smits <ruben [dot] smits [..] ...>
CommitDate: Wed Aug 17 09:42:19 2011 +0200

manifest: add pkg-config dependency and use it to get the eigen flags in
the manifest

Signed-off-by: Ruben Smits <ruben [dot] smits [..] ...>
orocos_kdl/manifest.xml | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/orocos_kdl/manifest.xml b/orocos_kdl/manifest.xml
index 1f208db..dc138ab 100644
--- a/orocos_kdl/manifest.xml
+++ b/orocos_kdl/manifest.xml
@@ -10,13 +10,12 @@ Library (KDL), distributed by the Orocos Project.
<review status="reviewed" notes=""/>
- <cpp cflags="-I${prefix}/install_dir/include"
lflags="-Wl,-rpath,${prefix}/install_dir/lib -L${prefix}/install_dir/lib
+ <cpp cflags="-I${prefix}/install_dir/include `pkg-config --cflags eigen3`"
lflags="-Wl,-rpath,${prefix}/install_dir/lib -L${prefix}/install_dir/lib
<doxymaker external="http://www.orocos.org/kdl" />

-<depend package="eigen"/>
-<rosdep name="eigen"/>
<rosdep name="cppunit"/>
+<rosdep name="pkg-config"/>

-- Ruben