[Bug 905] New: Deployer name not handled correctly

http://bugs.orocos.org/show_bug.cgi?id=905

Summary: Deployer name not handled correctly
Product: Toolchain
Version: 2.5.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: OCL
AssignedTo: orocos-dev [..] ...
ReportedBy: paul [dot] chavent [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

Created attachment 744
--> http://bugs.orocos.org/attachment.cgi?id=744
Change find_last_of in rfind.

I used to launch my orocos app with the deployer by invoking, for example
deployer-gnulinux -s config.xml Exp
and i had a node in config.xml <struct name="Exp"></struct>.

In 2.3 i started to have in my logs :
[ Warning][Logger] The given Deployer name Exp resembles a filename. Did
you forget to use '-s' ?

I didn't worried about this warning.

Still 2.5, it doesn't work anymore :

0.434 [ ERROR  ][DeploymentComponent::loadComponent] Unable to create Orocos
Component '': unknown component type.
0.434 [ Warning][DeploymentComponent::loadComponents] Could not configure
'Exp': No such peer.
0.452 [ ERROR  ][OrbRunner] Failed to load a component: aborting kick-start.
0.452 [ ERROR  ][TinyDemarshaller] Could not load Exp Error: Failed to open
file
0.452 [ ERROR  ][DeploymentComponent::loadComponents] Some error occured while
parsing Exp
0.452 [ ERROR  ][OrbRunner] Failed to load a component: aborting kick-start.


I read the code and it seems that there is a mistake in the use of the method
find_last_of. It search for *any* character of the match string.

I suppose we should use rfind for example ?

I join a patch.

[Bug 905] Deployer name not handled correctly

http://bugs.orocos.org/show_bug.cgi?id=905

Peter Soetens <peter [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |peter [..] ...
Resolution| |FIXED