[Bug 931] New: IFNDEF header guard for pinv_nso matches that of pinv preventing simultaneous include

http://bugs.orocos.org/show_bug.cgi?id=931

Summary: IFNDEF header guard for pinv_nso matches that of pinv
preventing simultaneous include
Product: KDL
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: major
Priority: P3
Component: Kinematic Solvers
AssignedTo: orocos-dev [..] ...
ReportedBy: andy [dot] somerville [..] ...
Estimated Hours: 0.0

Created attachment 777
--> http://bugs.orocos.org/attachment.cgi?id=777
chainiksolvervel_pinv_nso.hpp Ifndef guard fix

Problem:

chainiksolvervel_pinv.hpp
chainiksolvervel_pinv_nso.hpp

both use the same ifdef guard name:

KDL_CHAIN_IKSOLVERVEL_PINV_HPP

As a result both cannot be included in the same translation unit.

Work-around:

an #undef KDL_CHAIN_IKSOLVERVEL_PINV_HPP just before an offending include

While there is a work-around it may be difficult for developers/users to
determine the source of the problem in the first place which is why I marked it
as major.

Solution:

The latter file should have the following ifdef guard

KDL_CHAIN_IKSOLVERVEL_PINV_NSO_HPP

Affects all versions.
Patch against trunk attached.

Ruben Smits's picture

[Bug 931] IFNDEF header guard for pinv_nso matches that of pinv

http://bugs.orocos.org/show_bug.cgi?id=931

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |marioprats [..] ...

[Bug 931] IFNDEF header guard for pinv_nso matches that of pinv

Ruben Smits's picture

[Bug 931] IFNDEF header guard for pinv_nso matches that of pinv

http://bugs.orocos.org/show_bug.cgi?id=931

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |ruben.smits@intermodalics.e
| |u
Resolution| |FIXED