default Makefile

Hi,

attached some final patches that will enable ocl and rtt to compile out of the
box with rosmake.

Ruben

AttachmentSize
ocl-0001-add-Makefile.patch683 bytes
rtt-0001-add-default-Makefile.patch778 bytes

default Makefile

On Friday 26 November 2010 14:34:11 Ruben Smits wrote:
> Hi,
>
> attached some final patches that will enable ocl and rtt to compile out of
> the box with rosmake.

We need a broader discussion about this, especially since this also concerns
the orogen/typelib/... repositories. Since Orocos is robotics-specific, I don't
mind integrating (and even hope for it!) with other robotics software
projects.

So I don't mind this file being there (I don't use rosmake), but

* Shouldn't the 'error' message be more clear (a few lines of explanation why
it's not doing anything )?

* Shouldn't then all projects in the toolchain receive such a makefile, and
what will upstream think of that ?

Peter

Ruben Smits's picture

default Makefile

On Friday 26 November 2010 15:06:14 Peter Soetens wrote:
> On Friday 26 November 2010 14:34:11 Ruben Smits wrote:
> > Hi,
> >
> > attached some final patches that will enable ocl and rtt to compile out
> > of the box with rosmake.
>
> We need a broader discussion about this, especially since this also
> concerns the orogen/typelib/... repositories. Since Orocos is
> robotics-specific, I don't mind integrating (and even hope for it!) with
> other robotics software projects.
>
> So I don't mind this file being there (I don't use rosmake), but
>
> * Shouldn't the 'error' message be more clear (a few lines of explanation
> why it's not doing anything )?
It can :), this was just an initial attempt. I do not claim that the Makefile
is complete as it is right now ;)

I actually thought that others might put something usefull in the else
statement. Since I use rosmake for everything and my time constraints are
tight I did not spend a lot of time in investigating what could go into the
else statement. Probably something like the following could suffice:

default:
mkdir build; cd build; cmake ..;make

> * Shouldn't then all projects in the toolchain receive such a makefile, and
> what will upstream think of that ?

I have not looked into the other projects since a never use them. I'll give it
a try when I have time.

Ruben