Orocos-RTT installation path on Windows 64 bits

Hello,
when compiling Orocos-RTT in 32 bits mode on a 64 bits Windows OS, the
installation path is still forced to 'C:\Program Files\orocos' while it
should rather be 'C:\Program Files (x86)'. These lines in the main
CMakeLists.txt of Orocos-RTT are responsible of this behavior:



IF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
  IF (MSVC)
    SET(CMAKE_INSTALL_PREFIX
      "C:/Program Files/orocos" CACHE PATH "Orocos install prefix" FORCE
      )
  ENDIF(MSVC)
ENDIF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)



I think this may lead to confusion since on Windows x64 everything in
C:\Program Files\ should be compiled in 64 bits. Since version 2.8.3 (see
http://www.cmake.org/Bug/bug_view_page.php?bug_id=9992), CMake correctly
sets the default install path according to the target architecture, so we
should be able to use the same logic.

Is there any objection to adjust the installation path of orocos depending
on the target architecture on Windows? i.e.:

On Windows 32 bits:

C:\Program Files\orocos

On Windows 64 bits:

C:\Program Files\orocos (64 bits generators)
C:\Program Files (x86)\orocos (32 bits generators)

Philippe

Orocos-RTT installation path on Windows 64 bits

On Wed, Jun 8, 2011 at 4:18 PM, Philippe Hamelin
<philippe [dot] hamelin [..] ...> wrote:
> Hello,
> when compiling Orocos-RTT in 32 bits mode on a 64 bits Windows OS, the
> installation path is still forced to 'C:\Program Files\orocos' while it
> should rather be 'C:\Program  Files (x86)'. These lines in the main
> CMakeLists.txt of Orocos-RTT are responsible of this behavior:
> &#10;&gt; IF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)&#10;&gt;   IF (MSVC)&#10;&gt;     SET(CMAKE_INSTALL_PREFIX&#10;&gt;       &quot;C:/Program Files/orocos&quot; CACHE PATH &quot;Orocos install prefix&quot; FORCE&#10;&gt;       )&#10;&gt;   ENDIF(MSVC)&#10;&gt; ENDIF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)&#10;&gt;
> I think this may lead to confusion since on Windows x64 everything in
> C:\Program Files\ should be compiled in 64 bits. Since version 2.8.3
> (see http://www.cmake.org/Bug/bug_view_page.php?bug_id=9992), CMake
> correctly sets the default install path according to the target
> architecture, so we should be able to use the same logic.
> Is there any objection to adjust the installation path of  orocos depending
> on the target architecture on Windows? i.e.:
> On Windows 32 bits:
> C:\Program Files\orocos
> On Windows 64 bits:
> C:\Program Files\orocos (64 bits generators)
> C:\Program Files (x86)\orocos (32 bits generators)
> Philippe

I agree we must follow the standard practice of the platform we're building on.

Peter
--
Orocos-Dev mailing list
Orocos-Dev [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev

Orocos-RTT installation path on Windows 64 bits

2011/6/10 Philippe Hamelin <philippe [dot] hamelin [..] ...>

> 2011/6/10 Philippe Hamelin <philippe [dot] hamelin [..] ...>
>
>> 2011/6/9 Peter Soetens <peter [..] ...>
>>
>>> On Wed, Jun 8, 2011 at 4:18 PM, Philippe Hamelin
>>> <philippe [dot] hamelin [..] ...> wrote:
>>> > Hello,
>>> > when compiling Orocos-RTT in 32 bits mode on a 64 bits Windows OS, the
>>> > installation path is still forced to 'C:\Program Files\orocos' while it
>>> > should rather be 'C:\Program Files (x86)'. These lines in the main
>>> > CMakeLists.txt of Orocos-RTT are responsible of this behavior:
>>> > &#10;&gt;&gt;&gt; &gt; IF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)&#10;&gt;&gt;&gt; &gt;   IF (MSVC)&#10;&gt;&gt;&gt; &gt;     SET(CMAKE_INSTALL_PREFIX&#10;&gt;&gt;&gt; &gt;       &quot;C:/Program Files/orocos&quot; CACHE PATH &quot;Orocos install prefix&quot;&#10;&gt;&gt;&gt; FORCE&#10;&gt;&gt;&gt; &gt;       )&#10;&gt;&gt;&gt; &gt;   ENDIF(MSVC)&#10;&gt;&gt;&gt; &gt; ENDIF(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)&#10;&gt;&gt;&gt; &gt;
>>> > I think this may lead to confusion since on Windows x64 everything in
>>> > C:\Program Files\ should be compiled in 64 bits. Since version 2.8.3
>>> > (see http://www.cmake.org/Bug/bug_view_page.php?bug_id=9992), CMake
>>> > correctly sets the default install path according to the target
>>> > architecture, so we should be able to use the same logic.
>>> > Is there any objection to adjust the installation path of
>>> orocos depending
>>> > on the target architecture on Windows? i.e.:
>>> > On Windows 32 bits:
>>> > C:\Program Files\orocos
>>> > On Windows 64 bits:
>>> > C:\Program Files\orocos (64 bits generators)
>>> > C:\Program Files (x86)\orocos (32 bits generators)
>>> > Philippe
>>>
>>> I agree we must follow the standard practice of the platform we're
>>> building on.
>>>
>>>
>> I fixed this The patch [1] is available in my orocos-rtt branch
>> '2.3.1-sm-win32-fixes' [2] on github, with all others win32 patches awaiting
>> review.
>>
>> [1]
>> https://github.com/phamelin/orocos-rtt/commit/ac2803910ef85b89c1ac0cca7d...
>> [2] https://github.com/phamelin/orocos-rtt/tree/v2.3.1-sm-win32-fixes
>>
>>
>>
> Stop. I'm sorry I found a problem with this patch. I'm working on it.
>
>
Forget it. The patch is correct. It's friday...

Philippe