PATCH for KDL incorrect inline
| Submitted by snrkiwi on Thu, 2009-09-24 20:55 |
Vector2::Norm() is declared inline, but then is actually implemented
not-inline by being in the .cpp file (as are the other Norm()
functions). In certain situations, the KDL library ends up without the
Vector2::Norm() function as it was incorrectly declared inline and
hence wasn't compiled in to the library. User code then fails to link.
The attached patch fixes this.
Stephen
| Attachment | Size |
|---|---|
| 0001-Make-Vector2-Norm-function-not-inline.patch | 710 bytes |
PATCH for KDL incorrect inline
On Thu, Sep 24, 2009 at 22:52, S Roderick <kiwi [dot] net [..] ...> wrote:
> Vector2::Norm() is declared inline, but then is actually implemented
> not-inline by being in the .cpp file (as are the other Norm() functions). In
> certain situations, the KDL library ends up without the Vector2::Norm()
> function as it was incorrectly declared inline and hence wasn't compiled in
> to the library. User code then fails to link.
>
> The attached patch fixes this.
Has this patch been picked up on trunk already ?
Peter
PATCH for KDL incorrect inline
On Fri, Oct 2, 2009 at 3:45 PM, Peter Soetens
<Peter [dot] Soetens [..] ...> wrote:
> On Thu, Sep 24, 2009 at 22:52, S Roderick <kiwi [dot] net [..] ...> wrote:
>> Vector2::Norm() is declared inline, but then is actually implemented
>> not-inline by being in the .cpp file (as are the other Norm() functions). In
>> certain situations, the KDL library ends up without the Vector2::Norm()
>> function as it was incorrectly declared inline and hence wasn't compiled in
>> to the library. User code then fails to link.
>>
>> The attached patch fixes this.
>
> Has this patch been picked up on trunk already ?
By this (bij deze) :
svn ci src/frames.hpp -m "Fix for KDL incorrect inline, thanks SR
(again) for the patch"
Sending src/frames.hpp
Transmitting file data .
Committed revision 30613.
> Peter
> --
> Orocos-Dev mailing list
> Orocos-Dev [..] ...
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev
>