Three orogen/typegen patches worth considering for 2.2.0

The patches are against ad27be90504c030386d0704107dec34d472cb28d of the dfki
master.

The first patch takes a different approach in building typegen generated
typekits in a ros package tree. The changes are very isolated and properly
guarded by an 'if ROS_ROOT' such that it can't influence non-ros sytems. I
can't do it much more elegant than this. In ROS mode, we use rospack in
addition to pkgconfig to locate the .tlb files and we build the libs in
project/lib/orocos/types

The second patch is a no-brainer. Makes typegen -o ... truely optional.

The third patch is necessary for the reasons described in the commit message.
It makes typegen work also in 'stand alone' mode, ie a pure typekit project
generator, outside of a parent project.

The patches *still* rely on the fact that 'env.sh' is sourced, thus that you
use autoproj to build typelib and setup orogen.

My setup is this: put orocos-toolchain/ in the ROS_PACKAGE_PATH and do a
'autoproj build orogen' and source env.sh .

Any constructive comments greatly appreciated !

Peter

AttachmentSize
0001-typelib-support-typelibs-built-in-ros-package-trees.patch4.47 KB
0002-typegen-use-typekit-name-as-output-dir-if-o-was-not-.patch927 bytes
0003-typekit-also-symlink-from-typekit-to-self.patch1.47 KB

Three orogen/typegen patches worth considering for 2.2.0

On 11/26/2010 01:36 PM, Peter Soetens wrote:
>
> The patches are against ad27be90504c030386d0704107dec34d472cb28d of the dfki
> master.
>
> The first patch takes a different approach in building typegen generated
> typekits in a ros package tree. The changes are very isolated and properly
> guarded by an 'if ROS_ROOT' such that it can't influence non-ros sytems. I
> can't do it much more elegant than this. In ROS mode, we use rospack in
> addition to pkgconfig to locate the .tlb files and we build the libs in
> project/lib/orocos/types

> The second patch is a no-brainer. Makes typegen -o ... truely optional.
I applied these two, with a slight modification of the second one for
clarity.

> The third patch is necessary for the reasons described in the commit message.
> It makes typegen work also in 'stand alone' mode, ie a pure typekit project
> generator, outside of a parent project.
Also slightly modified (I apply the symlink only if standalone? is true)

They are on orocos-toolchain master

Sylvain