typelib cmake extension for plugin path

I have this path which fixes using typelib on the ROS Debian packages. The real
problem is that ROS deb builds don't use DESTDIR. The work-around is to let
the TYPELIB_PLUGIN_PATH be set cmake-wise, which the ROS-specific part of the
top-level Makefile does.

We start to depend more and more on the ros Debian packages for the toolchain,
so I hope it's not getting a veto.

Peter

AttachmentSize
0001-cmake-allow-to-override-the-plugin-path-for-typelib.patch1.93 KB

typelib cmake extension for plugin path

On 04/11/2011 03:17 PM, Peter Soetens wrote:
> I have this path which fixes using typelib on the ROS Debian packages. The real
> problem is that ROS deb builds don't use DESTDIR. The work-around is to let
> the TYPELIB_PLUGIN_PATH be set cmake-wise, which the ROS-specific part of the
> top-level Makefile does.
>
> We start to depend more and more on the ros Debian packages for the toolchain,
> so I hope it's not getting a veto.
Well, "yuk". Again. But I don't see how I could veto this anyways.

Sylvain

typelib cmake extension for plugin path

On 04/11/2011 03:31 PM, Sylvain Joyeux wrote:
> On 04/11/2011 03:17 PM, Peter Soetens wrote:
>> I have this path which fixes using typelib on the ROS Debian packages. The real
>> problem is that ROS deb builds don't use DESTDIR. The work-around is to let
>> the TYPELIB_PLUGIN_PATH be set cmake-wise, which the ROS-specific part of the
>> top-level Makefile does.
>>
>> We start to depend more and more on the ros Debian packages for the toolchain,
>> so I hope it's not getting a veto.
> Well, "yuk". Again. But I don't see how I could veto this anyways.
Mmmm ... Ambiguous statement.

Quite a few people depend on this, so the patch is needed and should
therefore be applied.

Please apply on orocos-toolchain/typelib.git

Sylvain

typelib cmake extension for plugin path

On Monday 11 April 2011 15:35:24 Sylvain Joyeux wrote:
> On 04/11/2011 03:31 PM, Sylvain Joyeux wrote:
> > On 04/11/2011 03:17 PM, Peter Soetens wrote:
> >> I have this path which fixes using typelib on the ROS Debian packages.
> >> The real problem is that ROS deb builds don't use DESTDIR. The
> >> work-around is to let the TYPELIB_PLUGIN_PATH be set cmake-wise, which
> >> the ROS-specific part of the top-level Makefile does.
> >>
> >> We start to depend more and more on the ros Debian packages for the
> >> toolchain, so I hope it's not getting a veto.
> >
> > Well, "yuk". Again. But I don't see how I could veto this anyways.
>
> Mmmm ... Ambiguous statement.
>
> Quite a few people depend on this, so the patch is needed and should
> therefore be applied.
>
> Please apply on orocos-toolchain/typelib.git
>
> Sylvain

Thanks, done.

Peter

typelib cmake extension for plugin path

On Apr 11, 2011, at 09:17 , Peter Soetens wrote:

> I have this path which fixes using typelib on the ROS Debian packages. The real
> problem is that ROS deb builds don't use DESTDIR. The work-around is to let
> the TYPELIB_PLUGIN_PATH be set cmake-wise, which the ROS-specific part of the
> top-level Makefile does.
>
> We start to depend more and more on the ros Debian packages for the toolchain,
> so I hope it's not getting a veto.

Does this only affect those using Orocos with ROS, or all Orocos users?
S

typelib cmake extension for plugin path

On 04/11/2011 03:27 PM, S Roderick wrote:
> On Apr 11, 2011, at 09:17 , Peter Soetens wrote:
>
>> I have this path which fixes using typelib on the ROS Debian packages. The real
>> problem is that ROS deb builds don't use DESTDIR. The work-around is to let
>> the TYPELIB_PLUGIN_PATH be set cmake-wise, which the ROS-specific part of the
>> top-level Makefile does.
>>
>> We start to depend more and more on the ros Debian packages for the toolchain,
>> so I hope it's not getting a veto.
>
> Does this only affect those using Orocos with ROS, or all Orocos users?
Looking at the patch, I would say that the intent is to affect only the
ROS users

Sylvain