On Feb 6, 2009, at 01:47 , Sylvain Joyeux wrote:

> As a general note, the build system of RTT is really in a need of
> cleanup.

Agreed.

> What I tried to do for CORBA is to set corba-specific variables
> (CORBA_*) in the discovery scripts (i.e. FindOmniORB and FindTAO)
> and use those variables in the right CMakeLists files. This really
> should be a rule of thumb for writing CMake code as it removes the
> bunch of side-effects that currently exist in the configuration
> process.
>
> Moreover, I'd feel much better if each external dependency would
> have its own Find*.cmake script instead of the generic overly
> complex check_* script.

The CMake recommended approach is a Find*.cmake and an (optional)
Use*.cmake for each dependancy. Personally I find that this approach
works really well, though some of the default CMake scripts need work
(eg UseSWIG is useless on the Mac). There has been some cleanup of our
CMake code over the past few months, and these kind of changes have
been worked in.

Some pages on writing Find*.cmake files

http://www.cmake.org/Wiki/CMake_HowToFindInstalledSoftware
http://www.cmake.org/Wiki/CMake:How_To_Find_Libraries ** though
does wrap some CMake stuff

> Finally, there is more complete (and tested) scripts for
> dependencies like boost, maybe we should use it.

I haven't looked at it, but sounds like a good idea.
S

On Feb 6, 2009, at 06:55 , Peter Soetens wrote:

> On Friday 06 February 2009 02:54:29 Stephen Roderick wrote:
>>
>> Sorry, but trunk with omniorb is broken. :-((
>>
>> You can't reset RTT_CFLAGS at the start of config/global_setup.cmake
>> as it's already been set to something useful in config/
>> check_depend.cmake. Only noticeable if you have boost in a non-
>> standard install dir, or are running RTAI, Xenomai or ecos.
>
> Ouch. We still need to reset RTT_CFLAGS somewhere, otherwise, it
> will just
> cumulate flags every cmake run due to
> SET(RTT_CFLAGS "${RTT_CFLAGS} -I${XENOMAI_INCLUDE_DIR}" CACHE
> INTERNAL "")
> in config/check_depend.cmake

Understood.

>> Someone put "-Wno-deprecated" into RTT_CFLAGS (also, it should have
>> been added and not blanketly assigned). This causes warnings on .c
>> files, as gcc says it is C++ only. We can't add this to RTT_CXXFLAGS
>> as that really isn't used. Rock <--> Us <--> Hard place. What
>> now?
>
> Remove it again until we got something better. So this goes out again:
>

> diff --git a/config/global_setup.cmake b/config/global_setup.cmake
> index 207d615..bfe66c6 100644
> --- a/config/global_setup.cmake
> +++ b/config/global_setup.cmake
> @@ -15,7 +15,7 @@ MESSAGE("CMAKE_VERSION: ${CMAKE_VERSION}")
> #
> # If we're using gcc, make sure the version is OK.
> #
> -SET(RTT_CXXFLAGS "")
> +SET(RTT_CFLAGS "")
 
NO! If you want to do this it has to be done before *both*  
global_setup.cmake and check_depend.cmake.
 
>> The corba-test seg faults, apparently on InitOrb(). Weird! This is a
>> default install of OminORB from MacPorts v1.7. Does this with or
>> without a naming service environment variable.
>
> The unit tests passed for both Omniorb and TAO on my gnulinux system
 
With TAO they passed on my system recently, though I have yet to try  
with up to date trunk.
S