[Bug 501] New: Unneeded display of logging messages

For more infomation about this bug, visit
Summary: Unneeded display of logging messages
Product: OCL
Version: trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: TaskBrowser
AssignedTo: orocos-dev [..] ...
ReportedBy: francois [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

When my application with teh deployer component I get the following output:

fcauwe@Titan:~/Project/orocos/deploy$ deployer-gnulinux --start deploy.xml
0.361 [ ERROR ][Logger] Adding Camera1 as new peer: Adding Measurement1 as new
peer: (Camera1) Could not initialize capturing...
Switched to : Deployer
[...]

The error "(Camera1) Could not initialize capturing..." got some other messages
in front.
When I check the logfile everything is fine:

0.357 [ Info ][Logger] Adding Camera1 as new peer: OK.
0.357 [ Info ][Logger] Creating PeriodicThread for scheduler: 0
0.358 [ Info ][TimerThreadInstance] PeriodicThread created with scheduler
type '0', priority 0 and period 0.05.
0.358 [ Info ][DeploymentComponent::loadComponent] Found factory for
Component type OCL::RegionFeature
0.359 [ Info ][Logger] Adding Measurement1 as new peer: OK.
0.359 [ Info ][Logger] Creating Connection Image:
0.359 [ Info ][Logger] Connected Port RawImage to connection Image
0.359 [ Info ][Logger] Connected Port RawImage to connection Image
0.359 [ Info ][Logger] Setting activity of Camera1
0.359 [ Info ][ExecutionEngine::setActivity] Camera1 is periodic.
0.359 [ Info ][PropertyLoader:configure] Configuring TaskContext 'Camera1'
with 'Camera1.cpf'.
0.361 [ ERROR ][Logger] (Camera1) Could not initialize capturing...

This is caused by the following code in DeploymentComponent.cpp
log(Error) << "Adding "<< newcomp.instance->getName() << " as new peer:
";
if (!this->addPeer( newcomp.instance ) ) {
log(Error) << "Failed !" << endlog(Error);
delete newcomp.instance;
return false;
}

[Bug 501] Unneeded display of logging messages

For more infomation about this bug, visit

Peter Soetens

<peter [dot] soetens [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
CC| |peter [dot] soetens [..] ...

--- Comment #5 from Peter Soetens

<peter [dot] soetens [..] ...> 2008-02-05 10:55:16 ---
Ok for me. Thanks for fixing.

[Bug 501] Unneeded display of logging messages

For more infomation about this bug, visit

Klaas Gadeyne <klaas [dot] gadeyne [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
CC| |klaas [dot] gadeyne [..] ...

--- Comment #4 from Klaas Gadeyne <klaas [dot] gadeyne [..] ...> 2008-01-22 09:54:03 ---
(In reply to comment #2)
> Created an attachment (id=220)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=220) [details]
> Quick patch
>
> A fix for this bug
>

[kgad@ampere ~/SVN/ocl-trunk]$
svn commit -m "fix bug #501: Unneeded display of logging messages. Patch by
Francois Cauwe. Buildtested on gnulinux" deployment/DeploymentComponent.cpp
Sending deployment/DeploymentComponent.cpp
Transmitting file data .
Committed revision 28853.

[Bug 501] Unneeded display of logging messages

For more infomation about this bug, visit

--- Comment #3 from François Cauwe <francois [..] ...> 2008-01-21 17:44:36 ---
Sorry for my somewhat unstructured comment #1 but I pushed by accident on
Commit...

[Bug 501] Unneeded display of logging messages

For more infomation about this bug, visit

--- Comment #2 from François Cauwe <francois [..] ...> 2008-01-21 17:34:32 ---
Created an attachment (id=220)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=220)
Quick patch

A fix for this bug

[Bug 501] Unneeded display of logging messages

For more infomation about this bug, visit

--- Comment #1 from François Cauwe <francois [..] ...> 2008-01-21 17:29:23 ---
(In reply to comment #0)
> When my application with teh deployer component I get the following output:
>

log(Error) << "Adding "<< newcomp.instance->getName() << " as new peer:
";
if (!this->addPeer( newcomp.instance ) ) {
log(Error) << "Failed !" << endlog(Error);
delete newcomp.instance;
return false;
}
log(Info) << " OK."<< endlog(Info);