[Bug 517] New: Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

           Summary: Getting submatrix fails in BOOST
           Product: BFL
           Version: trunk
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wrappers
        AssignedTo: bfl@lists.mech.kuleuven.be
        ReportedBy: tinne.delaet@mech.kuleuven.be
                CC: bfl@lists.mech.kuleuven.be
   Estimated Hours: 0.0

If you want to get a submatrix, not starting at the begin of the rows/columns,
the method failes.

e.g: matrix.sub(1,3,2,3)

Tinne

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.

[Bug 517] Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

Tinne De Laet <tinne.delaet@mech.kuleuven.be> changed:

           What    |Removed                     |Added
 --------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bfl@lists.mech.kuleuven.be  |tinne.delaet@mech.kuleuven.b
                   |                            |e
--- Comment #1 from Tinne De Laet <tinne.delaet@mech.kuleuven.be>  2008-02-21 12:43:07 ---

Created an attachment (id=239)

 --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=239)

this should solve the bug

[Bug 517] Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

Tinne De Laet <tinne.delaet@mech.kuleuven.be> changed:

           What    |Removed                     |Added
 --------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
--- Comment #2 from Tinne De Laet <tinne.delaet@mech.kuleuven.be>  2008-02-21 12:44:29 ---

Patch applied in revision 28989.

Sending matrix/matrix_BOOST.cpp
Transmitting file data .
Committed revision 28989.

[Bug 517] Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

--- Comment #3 from Klaas Gadeyne <klaas.gadeyne@fmtc.be>  2008-02-21 14:18:04 ---

Created an attachment (id=240)

 --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=240)

It does (partly), as good unit tests show (I think :-)

The following patch

- Modifies the units test so it covers the first bug
- Modifies similar unittests for SymmetricMatrix, Column- and Rowvectors
- Fixes similar bugs in those implementations

Note that

- this patch also reverts 28938, to check that all goes well, so please undo

this one

- I only ran the tests for boost ATM

[Bug 517] Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

Klaas Gadeyne <klaas.gadeyne@fmtc.be> changed:

           What    |Removed                     |Added
 --------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
                 CC|                            |klaas.gadeyne@fmtc.be
   Target Milestone|0.6.2                       |0.6.1
--- Comment #4 from Klaas Gadeyne <klaas.gadeyne@fmtc.be>  2008-02-21 14:20:22 ---

Reopening so we don't forget about this one (see patch)

[Bug 517] Getting submatrix fails in BOOST

For more infomation about this bug, visit <https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=517>

Tinne De Laet <tinne.delaet@mech.kuleuven.be> changed:

           What    |Removed                     |Added
 --------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED
--- Comment #5 from Tinne De Laet <tinne.delaet@mech.kuleuven.be>  2008-03-26 09:31:21 ---

Proposed patches applied in revision 29116.
(both tested for boost and lti)

Sending src/wrappers/matrix/matrix_BOOST.cpp
Sending src/wrappers/matrix/vector_BOOST.cpp
Sending tests/matrixwrapper_test.cpp
Transmitting file data ...
Committed revision 29116.

Tinne