[Bug 594] New: missing SIP does not disable PYTHON_BINDINGS

For more infomation about this bug, visit
Summary: missing SIP does not disable PYTHON_BINDINGS
Product: KDL
Version: kdl-trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Build system
AssignedTo: orocos-dev [..] ...
ReportedBy: wim [dot] meeussen [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

When buikding KDL with PYTHON_BINDINGS=ON but SIP not installed, I get a build
error (see below). Cmake detects if SIP is present or not, but does nothing to
prevent a build if SIP was not found.

A simple solution would be to generate an error message in Line 80 of
FindSIPandPython.cmake, disabling the "[g]enerate" option or cmake.

Wim

[ 91%] Building CXX object
src/CMakeFiles/orocos-kdl.dir/utilities/error_stack.o
[ 93%] Building CXX object src/CMakeFiles/orocos-kdl.dir/utilities/utility_io.o
[ 95%] Building CXX object src/CMakeFiles/orocos-kdl.dir/utilities/utility.o
Linking CXX shared library liborocos-kdl.so
[ 95%] Built target orocos-kdl
Scanning dependencies of target python
[ 95%] Generating Makefile
Parsing SIP files for 'PyKDL' library...
sh: /usr/bin/sip: not found

Ruben Smits's picture

[Bug 594] missing SIP does not disable PYTHON_BINDINGS

For more infomation about this bug, visit

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #2 from Ruben Smits <ruben [dot] smits [..] ...> 2008-10-30 09:16:06 ---
patch is applied to trunk/kdl

svn ci -m"fixes bug 594: missing SIP does not disable PYTHON_BINDINGS"
Sending CMakeLists.txt
Sending config/FindSIPandPython.cmake
Sending src/bindings/python/CMakeLists.txt
Transmitting file data ...
Committed revision 29717.

Ruben

Ruben Smits's picture

[Bug 594] missing SIP does not disable PYTHON_BINDINGS

For more infomation about this bug, visit

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
--------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|orocos- |ruben [dot] smits [..] ...
|dev [..] ... |

--- Comment #1 from Ruben Smits <ruben [dot] smits [..] ...> 2008-10-27 09:34:16 ---
Created an attachment (id=351)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=351)
disables building of python bindings if sip is not found

If you (wim) can test this patch i'll apply it to trunk.

Ruben