[Bug 687] New: getChain function does not clear chain before adding segments

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=687

Summary: getChain function does not clear chain before adding
segments
Product: KDL
Version: kdl-trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: Kinematic chains
AssignedTo: orocos-dev [..] ...
ReportedBy: meeussen [..] ...
CC: orocos-dev [..] ...
Estimated Hours: 0.0

Created an attachment (id=482)
--> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=482)
Fix getchain function when chain is not empty

I attached a patch for the getChain method on a tree. This method should clear
the chain first, before adding new segments. I also updated the test case to
catch this problem.

Wim

Ruben Smits's picture

[Bug 687] getChain function does not clear chain before adding s

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=687

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution| |FIXED
Status|NEW |RESOLVED

--- Comment #3 from Ruben Smits <ruben [dot] smits [..] ...> 2009-08-06 14:10:30 ---
My apologies,

I was looking at an older patch, which had the exact same name.

patch works fine and is committed:

svn ci -m"fixed Bug 687 - getChain function does not clear chain before
adding segments, thanks Wim for sending the patch"
Sending CMakeLists.txt
Sending src/tree.cpp
Sending tests/kinfamtest.cpp
Transmitting file data ...
Committed revision 30401

Ruben Smits's picture

[Bug 687] getChain function does not clear chain before adding s

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=687

--- Comment #2 from Ruben Smits <ruben [dot] smits [..] ...> 2009-08-06 11:34:21 ---
What's the reason for the addition of the link-names vector (how does it help
for the chain not being empty?)

The patch also contains parts of previous patches which were already applied on
trunk

Ruben

Ruben Smits's picture

[Bug 687] getChain function does not clear chain before adding s

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=687

Ruben Smits <ruben [dot] smits [..] ...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ruben [dot] smits [..] ...en.b
| |e

--- Comment #1 from Ruben Smits <ruben [dot] smits [..] ...> 2009-08-04 11:59:35 ---
The patch does not work on trunk, did you create it versus trunk? (at least
r30400.)

Ruben