OCL 1.10 cdeployer and deployer-corba does not compile anymore

compile error:

[ 85%] Building CXX object
bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o
/home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-svn/bin/cdeployer.cpp:
In function ‘int ORO_main_impl(int, char**)’:
/home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-svn/bin/cdeployer.cpp:83:
error: no matching function for call to
‘RTT::Corba::ControlTaskServer::Create(OCL::CorbaDeploymentComponent*,
bool, bool&)’
/home/rsmits/workspace/AdvRobCoSys/packages/orocos/rtt/rtt-1.10/rtt/include/rtt/corba/ControlTaskServer.hpp:140:
note: candidates are: static RTT::Corba::ControlTaskServer*
RTT::Corba::ControlTaskServer::Create(RTT::TaskContext*, bool)
make[2]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o] Error
1
make[1]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/all] Error 2
make: *** [all] Error 2

initiated by:

r30871 | psoetens | 2009-10-27 12:06:54 +0100 (Tue, 27 Oct 2009) | 3 lines

Add command line option to deployers, to optionally require CORBA name service

From: Stephen Roderick <kiwi [dot] net [..] ...>

fixed by:
src/bin/cdeployer.cpp

- if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
+if (0 == ControlTaskServer::Create( &dc, requireNameService ))

src/bin/deployer-corba.cpp

-if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
+if (0 == ControlTaskServer::Create( &dc, requireNameService ))

Ruben

OCL 1.10 cdeployer and deployer-corba does not compile anymore

On Mon, Nov 9, 2009 at 15:31, Ruben Smits <ruben [dot] smits [..] ...>wrote:

> compile error:
>
> [ 85%] Building CXX object
> bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o
>
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-svn/bin/cdeployer.cpp:
> In function ‘int ORO_main_impl(int, char**)’:
>
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-svn/bin/cdeployer.cpp:83:
> error: no matching function for call to
> ‘RTT::Corba::ControlTaskServer::Create(OCL::CorbaDeploymentComponent*,
> bool, bool&)’
>
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/rtt/rtt-1.10/rtt/include/rtt/corba/ControlTaskServer.hpp:140:
> note: candidates are: static RTT::Corba::ControlTaskServer*
> RTT::Corba::ControlTaskServer::Create(RTT::TaskContext*, bool)
> make[2]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o] Error
> 1
> make[1]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/all] Error 2
> make: *** [all] Error 2
>
> initiated by:
>
> r30871 | psoetens | 2009-10-27 12:06:54 +0100 (Tue, 27 Oct 2009) | 3 lines
>
> Add command line option to deployers, to optionally require CORBA name
> service
>
> From: Stephen Roderick <kiwi [dot] net [..] ...>
>
> fixed by:
> src/bin/cdeployer.cpp
>
> - if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
> +if (0 == ControlTaskServer::Create( &dc, requireNameService ))
>
> src/bin/deployer-corba.cpp
>
> -if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
> +if (0 == ControlTaskServer::Create( &dc, requireNameService ))
>

This fix is not correct. The change to ControlTaskServer could not make it
into the rtt-1.10 branch, so the sister patch for ocl-1.10 should not have
been applied in the first place.

I reverted the patch on the ocl-1.10 branch. It's still present on svn
trunk, where it belongs.

Peter

OCL 1.10 cdeployer and deployer-corba does not compile anymore

On Nov 9, 2009, at 09:31 , Ruben Smits wrote:

> compile error:
>
> [ 85%] Building CXX object
> bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-
> svn/bin/cdeployer.cpp:
> In function ‘int ORO_main_impl(int, char**)’:
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/ocl/ocl-1.10/ocl-
> svn/bin/cdeployer.cpp:83:
> error: no matching function for call to
> ‘RTT::Corba::ControlTaskServer::Create(OCL::CorbaDeploymentComponent*,
> bool, bool&)’
> /home/rsmits/workspace/AdvRobCoSys/packages/orocos/rtt/rtt-1.10/rtt/
> include/rtt/corba/ControlTaskServer.hpp:140:
> note: candidates are: static RTT::Corba::ControlTaskServer*
> RTT::Corba::ControlTaskServer::Create(RTT::TaskContext*, bool)
> make[2]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/cdeployer.o] Error
> 1
> make[1]: *** [bin/CMakeFiles/cdeployer-gnulinux.dir/all] Error 2
> make: *** [all] Error 2
>
> initiated by:
>
> r30871 | psoetens | 2009-10-27 12:06:54 +0100 (Tue, 27 Oct 2009) | 3
> lines
>
> Add command line option to deployers, to optionally require CORBA
> name service
>
> From: Stephen Roderick <kiwi [dot] net [..] ...>
>
> fixed by:
> src/bin/cdeployer.cpp
>
> - if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
> +if (0 == ControlTaskServer::Create( &dc, requireNameService ))
>
> src/bin/deployer-corba.cpp
>
> -if (0 == ControlTaskServer::Create( &dc, true, requireNameService ))
> +if (0 == ControlTaskServer::Create( &dc, requireNameService ))

Sorry if I broke stuff, but the above corrections don't look right. In
r30870 the function is declared

static ControlTaskServer* Create(TaskContext* tc, bool use_naming =  
true, bool require_name_service =false);

so it should take 3 variables ok (the second and third are bool's).
Did you upgrade/install RTT prior to building OCL? If not then I'm
confused ...
Stephen